[Refactor] Remove no-explicit-any suppressions: batch 3 (integrations) - #2309

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Part of the no-explicit-any suppression elimination campaign. This is batch 3. It follows #2281 (batch 1) and #2286 (batch 2). The campaign tracks the suppressions ledger in src/eslint-suppressions.json; this batch has no separate tracking issue.

Description

Batch 3 removes every no-explicit-any suppression in src/integrations. The ledger shrinks from 3,315 suppressions across 292 files to 2,884 suppressions across 269 files. That removes all 431 suppressed anys in the 23 integrations files, and the ledger entry for each file is gone.

The fixes are real type fixes. No as any, no @ts-ignore, and no moved suppressions. Assertions and runtime behavior stay unchanged. The main patterns:

• Private members are accessed with bracket notation (diffViewProvider["relPath"]), per AGENTS.md.
• Test doubles use the typed helpers in src/test-utils/vscode.ts, or full structural vscode.Tab / TabGroup doubles. Double assertions appear once per double at its construction site, with a comment that names the members the double provides.
• Theme JSON in getTheme.ts now uses recursive JsonValue / ParsedTheme types instead of any.
• execSync failure paths in the terminal stream helpers use an ExecException intersection instead of error: any.
• The __TEST_ENV__ global uses a proper var declaration instead of (global as any).

Two production files change: src/integrations/theme/getTheme.ts (JSON types plus one documented theme conversion) and src/integrations/editor/DiffViewProvider.ts (typed rejection handler). All other changes are test files. No user-facing behavior changes.

Test Procedure

Validation ran after a rebase onto latest main (debd3c7). All gates pass:

• Focused tests: all src/integrations suites pass. 564 test files: 564 passed, 23 skipped (platform-gated shell and PowerShell suites). Per-file runs: DiffViewProvider.spec 71/71, TerminalProfile.spec 57/57, TerminalProcess.spec 41/41, TerminalRegistry.spec 19/19, TerminalProcess.test 7/7, ExecaTerminalProcess.spec 19/19, OutputInterceptor 25/25, open-file 8/8, EditorUtils 8/8, InterpretExitCode 9/9, kimi-code oauth + export-markdown 35/35.
• Lint: pnpm lint passes with zero warnings across all 12 workspace packages. Each touched file was pruned with eslint --prune-suppressions --max-warnings=0.
• Type checks: pnpm check-types passes (root project plus 11 turbo tasks).
• Full extension suite: pnpm --dir src test passes. 12,276 tests passed, 39 skipped (platform-gated).
• Repo-wide pnpm test: 14/14 turbo tasks pass. The first full run had one transient failure in the extension suite that matches the known order-dependent extension.spec.ts flake. Two later full runs pass clean. Recorded, not chased.
• Pre-commit hooks pass on the committed tree (staged-file ESLint at --max-warnings=0, Prettier, mutation judgement).

Guardrail scan since #2279: main added no new suppressions. Main added one direct vi.clearAllMocks() call in webview-ui/.../SettingsView.spec.tsx (#2271). The webview workspace has no reset helper, and the #2279 guardrail covers the extension workspace only, so this matches the current webview convention. Recorded here, not changed in this batch.

Pre-Submission Checklist

• Issue Linked: Covered by the campaign; follows [Refactor] Remove no-explicit-any suppressions: batch 1 (utils) #2281 and [Refactor] Remove no-explicit-any suppressions: batch 2 (small directories) #2286 (no separate issue for this batch).
• Scope: Changes cover one campaign batch: src/integrations suppressions only.
• Self-Review: Full diff reviewed. No as any, no @ts-ignore, and no new suppressions. The ledger change removes exactly 23 files; no entry is added or raised.
• Writing Style: Title and description follow Simplified Technical English.
• Testing: All touched files keep their focused suites green; no test assertions changed.
• Test Helpers: Doubles use src/test-utils/vscode.ts helpers, or single construction-site double assertions with comments naming the provided members.
• Visual Snapshot: Not applicable. No UI change.
• Documentation Impact: No documentation updates are required. No functionality changed.
• Contribution Guidelines: Read and followed.

Visual Snapshots

Not applicable. This change is type-level only. No rendered UI changes.

Videos

Not applicable. No interaction or animation changes.

Documentation Updates

• No documentation updates are required.
• Yes, documentation updates are required.

No functionality changed, so the docs repository needs no companion PR.

Additional Notes

Ledger delta: 3,315 suppressions across 292 files → 2,884 suppressions across 269 files (−431 suppressions, −23 files). The next batch can pick up any remaining directory. The workspace baseline needs packages/build compiled and pnpm --dir src bundle run before __tests__/dist_assets.spec.ts can pass; the sandbox needed that step once.